oci: fix race when the container exits before start returns#3125
oci: fix race when the container exits before start returns#3125giuseppe wants to merge 1 commit intocontainers:masterfrom
Conversation
fix a race when the container process exits faster than we are notified from the OCI runtime start command. When it happens, the cleanup process exits immediately as the container is reported as running. Do the check while we hold the lock, so we won't release it with an invalid status. Reproducer: NOTIFY_SOCKET=/run/user/1000/notify podman run fedora sh -c ' echo hello' Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
The cleanup process exiting immediately shouldn't happen - it should wait until start is done, then sync state and pick up that the container is running... So if this actually fixes us, we still have some serious issues. This patch can't hurt, though, let me test. |
|
This does fix it. Which means that locking isn't working. That's really, really not good. |
|
Trivial test indicates that locking does seem to work for rootless. |
|
I know what this is. This isn't the fix. |
|
The actual issue:
|
|
#3127 to fix |
github-actions
bot
added
the
locked - please file new issue/PR
3 participants
fix a race when the container process exits faster than we are
notified from the OCI runtime start command. When it happens, the
cleanup process exits immediately as the container is reported as
running. Do the check while we hold the lock, so we won't release it
with an invalid status.
Reproducer:
NOTIFY_SOCKET=/run/user/1000/notify podman run fedora sh -c ' echo hello'
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com